potiuk commented on a change in pull request #20795:
URL: https://github.com/apache/airflow/pull/20795#discussion_r783059967
##########
File path: airflow/utils/operator_helpers.py
##########
@@ -164,10 +164,7 @@ def determine(
def unpacking(self) -> Mapping[str, Any]:
"""Dump the kwargs mapping to unpack with ``**`` in a function call."""
- # Context is a TypedDict at lint time, and Mypy would complain it
cannot
- # be used in isinstance. But the call works at runtime since the type
is
- # actually implemented as a custom mapping, so we ignore the Mypy
error.
- if self._wildcard and isinstance(self._kwargs, Context): # type:
ignore
+ if self._wildcard and isinstance(self._kwargs, Context):
Review comment:
```
pre-commit run mypy --all-files 2>&1 | sed -r
"s/\x1B\[([0-9]{1,2}(;[0-9]{1,2})?)?[mGK]//g" | grep "error:" | wc
105 292 8934
```
BTW. The numbers might not add up. It's quite possible that fixing a mypy
error in "selective" check will generate more errors elsewhere (in providers
for example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
