ashb commented on a change in pull request #20795:
URL: https://github.com/apache/airflow/pull/20795#discussion_r783029207
##########
File path: airflow/utils/operator_helpers.py
##########
@@ -164,10 +164,7 @@ def determine(
def unpacking(self) -> Mapping[str, Any]:
"""Dump the kwargs mapping to unpack with ``**`` in a function call."""
- # Context is a TypedDict at lint time, and Mypy would complain it
cannot
- # be used in isinstance. But the call works at runtime since the type
is
- # actually implemented as a custom mapping, so we ignore the Mypy
error.
- if self._wildcard and isinstance(self._kwargs, Context): # type:
ignore
+ if self._wildcard and isinstance(self._kwargs, Context):
Review comment:
Despite mypy complaining about this before _in this PR_ it's now not, at
least not for me when I run `pre-commit run -a mypy` locally.
I want to see what number CI gets -- it should be 102 errors left for the
first mypy job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
