Bowrna commented on pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#issuecomment-1030120241


   > > yes, I could understand this part, but figuring out if the variable 
remains constant / varies depending on 'parameters' passed to breeze command is 
the part where I am confused as you mentioned. Say example `USE_AIRFLOW_VERSION 
` does it have to go to global constants or dataclass. Does the user can set 
this value / does it have to remain constant? How do I figure out that? @potiuk
   > 
   > It's passed by parameter (`--use-airflow-version` in this case) , so it 
should be in dataclass. You should not be able to change a constants with the 
command line parameter really :)
   
   Cool :) I didn't notice the parameter. I will remember this way that 
parameters are user-modifiable and its better to place them in dataclass  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to