[GitHub] [airflow] raphaelauv commented on a change in pull request #21429: Fix docker behaviour with byte lines returned

Tue, 08 Feb 2022 09:36:53 -0800 


raphaelauv commented on a change in pull request #21429:
URL: https://github.com/apache/airflow/pull/21429#discussion_r801894265



##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -222,7 +231,7 @@ def get_hook(self) -> DockerHook:
             tls=self.__get_tls_config(),
         )
 
-    def _run_image(self) -> Optional[str]:
+    def _run_image(self) -> Optional[Union[List[str], str]]:

Review comment:
       what is the convention?
   ```python
   Optional[Union[List[str], str]]:
   ``` 
   or
    
   ```python
   Union[None,List[str], str]:
   ```
   
   
   ![Screenshot from 2022-02-08 
18-36-03](https://user-images.githubusercontent.com/10202690/153043737-48e56a6c-d38b-402a-b642-b2c98912090c.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to