potiuk commented on a change in pull request #21429:
URL: https://github.com/apache/airflow/pull/21429#discussion_r801899117
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -222,7 +231,7 @@ def get_hook(self) -> DockerHook:
tls=self.__get_tls_config(),
)
- def _run_image(self) -> Optional[str]:
+ def _run_image(self) -> Optional[Union[List[str], str]]:
Review comment:
Both work. But I personally prefer optional[Union] as it is more
explicit IMHO.
I am not sure we have agreed to a particular one :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
