jedcunningham commented on a change in pull request #21429:
URL: https://github.com/apache/airflow/pull/21429#discussion_r801903053
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -487,10 +496,48 @@ def test_execute_xcom_behavior_bytes(self):
xcom_all_result = xcom_all_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
+ # Those values here are different than log above as they are from setup
assert xcom_push_result == 'container log 2'
assert xcom_all_result == ['container log 1', 'container log 2']
assert no_xcom_push_result is None
+ def test_execute_xcom_behavior_no_result(self):
+ self.log_messages = []
+ self.client_mock.pull.return_value = [b'{"status":"pull log"}']
+ self.client_mock.attach.return_value = iter([])
+ # Make sure the logs side effect is updated after the change
+ self.client_mock.logs.side_effect = iter([])
+
+ kwargs = {
+ 'api_version': '1.19',
+ 'command': 'env',
+ 'environment': {'UNIT': 'TEST'},
+ 'private_environment': {'PRIVATE': 'MESSAGE'},
+ 'image': 'ubuntu:latest',
+ 'network_mode': 'bridge',
+ 'owner': 'unittest',
+ 'task_id': 'unittest',
+ 'mounts': [Mount(source='/host/path', target='/container/path',
type='bind')],
+ 'working_dir': '/container/path',
+ 'shm_size': 1000,
+ 'host_tmp_dir': '/host/airflow',
+ 'container_name': 'test_container',
+ 'tty': True,
+ }
+
+ xcom_push_operator = DockerOperator(**kwargs, do_xcom_push=True,
xcom_all=False)
+ xcom_all_operator = DockerOperator(**kwargs, do_xcom_push=True,
xcom_all=True)
+ no_xcom_push_operator = DockerOperator(**kwargs, do_xcom_push=False)
+
+ xcom_push_result = xcom_push_operator.execute(None)
+ xcom_all_result = xcom_all_operator.execute(None)
+ no_xcom_push_result = no_xcom_push_operator.execute(None)
+
+ # Those values here are different than log above as they are from setup
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
