potiuk commented on a change in pull request #21145: URL: https://github.com/apache/airflow/pull/21145#discussion_r808957232
########## File path: dev/breeze/tests/test_docker_command_utils.py ########## @@ -0,0 +1,102 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from unittest import mock +from unittest.mock import call + +from airflow_breeze.utils.docker_command_utils import check_docker_version + + [email protected]('airflow_breeze.utils.docker_command_utils.run_command') [email protected]('airflow_breeze.utils.docker_command_utils.console') +def test_check_docker_version_unknown(mock_console, mock_run_command): Review comment: Hey @Bowrna - here are few examples of tests using mocking approach. Actually it was alredy useful to add the tests because I actually FOUND two small issues when I added them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
