potiuk commented on a change in pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#discussion_r808959780
##########
File path: dev/breeze/src/airflow_breeze/utils/docker_command_utils.py
##########
@@ -116,7 +116,7 @@ def check_docker_permission(verbose) -> bool:
def compare_version(current_version: str, min_version: str) -> bool:
- return version.parse(current_version) > version.parse(min_version)
+ return version.parse(current_version) >= version.parse(min_version)
Review comment:
This is the first error I found (the 20.10.0 version was actually
failing the check :scream: )
##########
File path: dev/breeze/src/airflow_breeze/utils/docker_command_utils.py
##########
@@ -145,7 +145,7 @@ def check_docker_version(verbose: bool):
else:
console.print(
f'Your version of docker is too old:{docker_version}.
Please upgrade to \
- at least ${MIN_DOCKER_VERSION}'
+ at least {MIN_DOCKER_VERSION}'
Review comment:
And this is the second (there was extra '$' printed.
So if you ask me if it is worth to add the tests - yep. It is :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
