ephraimbuddy commented on a change in pull request #21273:
URL: https://github.com/apache/airflow/pull/21273#discussion_r809401716
##########
File path:
airflow/migrations/versions/7b2661a43ba3_taskinstance_keyed_to_dagrun.py
##########
@@ -337,7 +337,7 @@ def downgrade():
batch_op.drop_constraint('task_instance_pkey', type_='primary')
batch_op.alter_column('execution_date', existing_type=dt_type,
existing_nullable=True, nullable=False)
batch_op.alter_column(
- 'dag_id', existing_type=string_id_col_type,
existing_nullable=True, nullable=True
+ 'dag_id', existing_type=string_id_col_type,
existing_nullable=True, nullable=False
Review comment:
Tried all of the above but it didn't work. Tried a couple of other
things but none worked. At last what I found out is, for `MSSQL` the dag_id was
not nullable before the upgrade that made `dag_id` nullable in other DBs. It
created a clustered, unique key and made sure those columns were not nullable.
I don't think it's possible to make the `dag_id` nullable for mssql and
still create a primary key out of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
