ephraimbuddy commented on a change in pull request #21273:
URL: https://github.com/apache/airflow/pull/21273#discussion_r809405410



##########
File path: 
airflow/migrations/versions/7b2661a43ba3_taskinstance_keyed_to_dagrun.py
##########
@@ -337,7 +337,7 @@ def downgrade():
         batch_op.drop_constraint('task_instance_pkey', type_='primary')
         batch_op.alter_column('execution_date', existing_type=dt_type, 
existing_nullable=True, nullable=False)
         batch_op.alter_column(
-            'dag_id', existing_type=string_id_col_type, 
existing_nullable=True, nullable=True
+            'dag_id', existing_type=string_id_col_type, 
existing_nullable=True, nullable=False

Review comment:
       > What do you get with `op.execute('DROP INDEX task_instance_pkey ON 
task_instance')` instead?
   
   It gave this error:
   ```
   An explicit DROP INDEX is not allowed on index 
'task_instance.task_instance_pkey'. It is being used for PRIMARY KEY constraint 
enforcement
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to