dstandish commented on a change in pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#discussion_r815219255
##########
File path:
airflow/migrations/versions/c306b5b5ae4a_switch_xcom_table_to_use_run_id.py
##########
@@ -41,7 +41,7 @@
def _get_new_xcom_columns() -> Sequence[Column]:
return [
- Column("dagrun_id", Integer(), nullable=False),
+ Column("dag_run_id", Integer(), nullable=False),
Review comment:
i understand, but i disagree.
in my experience, if you have an order_line table, you call the identity
column either `order_line_id` or simply `id`, but not `orderline_id`. you
don't violate your snake case convention for identity columns.
and there's good reason we use snake case. consider table
`ab_permission_view_role`. would you really want to call that table's identity
column `abpermissionviewrole_id`?
actually, looking at that table, its ident col is `id` -- maybe we should
just go with that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
