dstandish commented on pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#issuecomment-1051703737


   side note, question for @uranusjr :
   this bit here: 
https://github.com/apache/airflow/pull/21806/files/f3aaa031be561d3e6671dbd734bb427fe283ddf8#diff-3f95f161bd9ef4bb455611e0c58583899769360afc53f755cd1577cf194553c5R70-R79
   
   now that we are keying xcom to the PK of dag_run, we should be able to look 
up the dag run by the PK rather  than doing this join:
   ```python
           primaryjoin="""and_(
               BaseXCom.dag_id == foreign(DagRun.dag_id),
               BaseXCom.run_id == foreign(DagRun.run_id),
           )""",
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to