dstandish commented on a change in pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#discussion_r815261308
##########
File path:
airflow/migrations/versions/c306b5b5ae4a_switch_xcom_table_to_use_run_id.py
##########
@@ -41,7 +41,7 @@
def _get_new_xcom_columns() -> Sequence[Column]:
return [
- Column("dagrun_id", Integer(), nullable=False),
+ Column("dag_run_id", Integer(), nullable=False),
Review comment:
Ah i see we're talking about the column in the xcom table, which is
pointing to the dag run table.
The PK in dag_run is already `id`.
So yeah, same reasoning essentially applies. When we refer to id col of a
table, it should be `f"{table_name}_{col_name}"`. I don't think there's really
any reason to diverge from this convention here. There's no "run_id" on the
"dag" table so there's no conflict here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
