omusavi commented on a change in pull request #5319: [AIRFLOW-4564] Azure
Container Instance improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r288235796
##########
File path: airflow/contrib/operators/azure_container_instances_operator.py
##########
@@ -208,15 +200,16 @@ def _monitor_logging(self, ci_hook, resource_group,
name):
last_state = None
last_message_logged = None
last_line_logged = None
- for _ in range(43200): # roughly 12 hours
+ while True:
Review comment:
instead of while(true), should we instead have a setting for time-out value
so DAGs don't just get stuck?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
