omusavi commented on a change in pull request #5319: [AIRFLOW-4564] Azure
Container Instance improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r288235446
##########
File path: airflow/contrib/operators/azure_container_instances_operator.py
##########
@@ -43,11 +42,6 @@
['conn_id', 'account_name', 'share_name', 'mount_path', 'read_only'],
)
-DEFAULT_ENVIRONMENT_VARIABLES = {} # type: Dict[str, str]
Review comment:
Any reason to remove these (including the DEFAULT_MEMORY_IN_GB) instead of
inlining as done in the constructor? It reads better with constants, and I
believe that was a change made in the original PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
