omusavi commented on a change in pull request #5319: [AIRFLOW-4564] Azure
Container Instance improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r288235016
##########
File path: airflow/contrib/operators/azure_container_instances_operator.py
##########
@@ -104,11 +99,9 @@ class AzureContainerInstancesOperator(BaseOperator):
)
"""
- template_fields = ('name', 'environment_variables')
-
@apply_defaults
def __init__(self, ci_conn_id, registry_conn_id, resource_group, name,
image, region,
- environment_variables=None, volumes=None, memory_in_gb=None,
cpu=None,
Review comment:
In the original PR for this file, it was requested the None be used as
default params:
https://github.com/apache/airflow/pull/4121
https://graysonkoonce.com/always-use-none-for-default-args-in-python/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
