uranusjr commented on code in PR #22804:
URL: https://github.com/apache/airflow/pull/22804#discussion_r844588193
##########
airflow/www/templates/airflow/ti_log.html:
##########
@@ -53,6 +53,7 @@ <h4>{{ title }}</h4>
<div class="col-md-4 text-right">
<a class="btn btn-default" onclick="scrollBottomLogs()">Jump To End</a>
<a class="btn btn-default" onclick="toggleWrapLogs()">Toggle Wrap</a>
+ <a class="btn btn-default" onclick="downloadActiveLog()">Download</a>
Review Comment:
Can this be a “real” `<a>` tag `href` constructed when the tab is shown?
Should probably add either `target` or
[`download`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download)
so the file doesn’t open in the current browser tab).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
