uranusjr commented on code in PR #22804:
URL: https://github.com/apache/airflow/pull/22804#discussion_r844731905
##########
airflow/www/templates/airflow/ti_log.html:
##########
@@ -53,6 +53,7 @@ <h4>{{ title }}</h4>
<div class="col-md-4 text-right">
<a class="btn btn-default" onclick="scrollBottomLogs()">Jump To End</a>
<a class="btn btn-default" onclick="toggleWrapLogs()">Toggle Wrap</a>
+ <a class="btn btn-default" onclick="downloadActiveLog()">Download</a>
Review Comment:
If the server already sets `attachment` we can omit `download`, yes. Setting
`href` as you outlined looks good to me. (Needs @bbovenzi to take another look.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
