uranusjr commented on code in PR #22804:
URL: https://github.com/apache/airflow/pull/22804#discussion_r845710038
##########
airflow/www/static/js/ti_log.js:
##########
@@ -153,4 +171,10 @@ $(document).ready(() => {
const autoTailing = i === TOTAL_ATTEMPTS;
autoTailingLog(i, null, autoTailing);
}
+
+ setDownloadUrl();
+ $('#ti_log_try_index_list a').click(function () {
+ const tryNumber = $(this).attr('href').replace(/\D/g, '');
+ setDownloadUrl(tryNumber);
Review Comment:
Regex doesn’t feel like a good idea here. Maybe put this value in a data
attribute instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
