potiuk commented on code in PR #23308:
URL: https://github.com/apache/airflow/pull/23308#discussion_r860291672
##########
dev/breeze/src/airflow_breeze/commands/configuration_and_maintenance.py:
##########
@@ -247,7 +248,7 @@ def setup_autocomplete(verbose: bool, dry_run: bool, force:
bool, answer: Option
)
console.print(f"[bright_blue]Activation command script is available here:
{autocomplete_path}[/]\n")
console.print(f"[bright_yellow]We need to add above script to your
{detected_shell} profile.[/]\n")
- given_answer = user_confirm("Should we proceed ?",
default_answer=Answer.NO, timeout=3)
+ given_answer = user_confirm("Would you like me to do that automatically?",
default_answer=Answer.NO, timeout=30)
Review Comment:
I thik we should rather remove the timeout here. It is potentially
disruptive operation indeed so any timeout here is bad and the user should take
some action once they started the action via running command.
Timeout is mostly reserved for commands which are "by-products". For
example when you run "breeze shell" and image is outdated, you are asked
whether to rebuild it - but this is not what you intended to do - you intended
to run "breeze shell" command. Asking for image is "accidental" and timeout is
there to allow to eventually do the original command.
Here you really want to run the command. This is the intention. So while
asking question for confirmation is fine (as this is disruptive command
potentially), timeout here makes little sense- because there is nothing else to
do on timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
