potiuk commented on code in PR #23308:
URL: https://github.com/apache/airflow/pull/23308#discussion_r860273943
##########
breeze:
##########
@@ -64,7 +64,7 @@ function check_breeze_installed() {
if "${MY_DIR}/scripts/tools/confirm" "Installing breeze?"; then
pipx ensurepath --force
pipx install -e "${MY_DIR}/dev/breeze/" --force
- ${BREEZE_BINARY} setup-autocomplete --force --answer yes
+ ${BREEZE_BINARY} setup-autocomplete
Review Comment:
I think we should rather warn about replacing the auto-complete in the first
question and continue using --force --yes here. Asking question twice only
makes sense when you do something really disruptive and want the user to
absolutely confirm that they know what they are doing.
Installing breeze without autocomplete makes little sense and you can
already do it with:
```
pipx install -e ./dev/breeze
```
This is described in the docs as "viable option".
But the `./breeze` script is just "convenience installation" and is only
here for backwards-compatibility with old breeze and will be eventually renamed
to `./scripts/tools/install_breeze.sh` iI think . So it should do a "complete
instlalation" - including the autocomplete.
Why ? Big part of `breeze's` power comes from autocomplete being available
(for example using `static-checks` instead of `pre-commit` is justified because
we can auto-complete all pre-commit checks. Unfortunately the original author
of pre-commit is quite allergic to autocomplete
https://github.com/pre-commit/pre-commit/issues/1119 and we had to impleement
our own command. So when installing via script we should do both IMHO.
Otherwise the user has to answer yes twice - which makes little sense and is
a bit strange. Usually when you run
a tool or script and you answer "yes" you do not have to repeat the answer.
IThere should be IMHO very few cases where users should answer questions twice
- mostly when you want to do thing that might be very disruptive.
Happy to hear the reasoning why two questions are better, but I thinl just
warning at the first question shoudl be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
