potiuk commented on code in PR #23308:
URL: https://github.com/apache/airflow/pull/23308#discussion_r860292708
##########
dev/breeze/src/airflow_breeze/utils/confirm.py:
##########
@@ -75,9 +75,8 @@ def user_confirm(
else:
Review Comment:
Actually I think there is another bug here that needs fixing.
Default_answer should have two meanings:
1) when timeout is ther and you do not answer, the default one is returned.
2) when you press enter without providing answer and default is set - the
default answer should be returned.
Case 2) is not handled here only 1) actually. It would be great to fix it
while you are at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
