pankajastro commented on PR #24306: URL: https://github.com/apache/airflow/pull/24306#issuecomment-1150033369
> I mean if user set `emr_conn_id="this_connection_not_exists"` this connection not exists and should raise an error rather than set to empty extras. And `emr_conn_id=None` - is not mandatory. > > I think it also required make changes in operator > > https://github.com/apache/airflow/blob/287fc4bdeb107fc81653d3a6721f9f5b87b90529/airflow/providers/amazon/aws/operators/emr.py#L304-L305 Ok, So behaviour should be like - if aws_conn_id does not exist raise an error like earlier - if emr_conn_id container auth param like `aws_access_key_id` etc raise error like earlier - if emr_conn_id does not exist then make `config` as empty that way emr_conn_id will not be mandatory We can't keep aws_conn_id and emr_conn_id default values None because if the user do pass aws_conn_id then we accuse that the value is `aws_default` across the operator/sensor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
