Taragolis commented on PR #24306: URL: https://github.com/apache/airflow/pull/24306#issuecomment-1150222260
> Then this will be a breaking change if someone has created emr_conn_id with the name emr_default and not passing emr_conn_id param in operator, isn't it? Yeah, you right, for example EMR example DAG doesn't set `emr_conn_id`, it probably won't hurt if it uses empty connection. But if user previously stored some values in `emr_conn_id` it will https://github.com/apache/airflow/blob/047a6162b0b4cbf07fe2fd978e335839a7d3900b/airflow/providers/amazon/aws/example_dags/example_emr.py#L77-L80 So it would be nice update docstring about behaviour of `emr_conn_id` as well as for `aws_conn_id` (it could be grabbed from AwsBaseHook) https://github.com/apache/airflow/blob/047a6162b0b4cbf07fe2fd978e335839a7d3900b/airflow/providers/amazon/aws/hooks/base_aws.py#L378-L383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
