pankajastro commented on PR #24306: URL: https://github.com/apache/airflow/pull/24306#issuecomment-1150171541
> > yep So, if I'll change the [__init__](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/operators/emr.py#L301) method of the operator to ``` def __init__( self, *, aws_conn_id: str = 'aws_default', emr_conn_id: Optional[str] = 'emr_default', job_flow_overrides: Optional[Union[str, Dict[str, Any]]] = None, region_name: Optional[str] = None, **kwargs, ): ``` Then from the code execution point of view, this is effectively no change and if I'll do ``` def __init__( self, *, aws_conn_id: str = 'aws_default', emr_conn_id: Optional[str] = None, job_flow_overrides: Optional[Union[str, Dict[str, Any]]] = None, region_name: Optional[str] = None, **kwargs, ): ``` Then this will be a breaking change if someone has created emr_conn_id with the name emr_default and not passing emr_conn_id param in operator, isn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
