[GitHub] [airflow] Taragolis opened a new pull request, #24425: Preserve original order of providers' connection extra fields

Mon, 13 Jun 2022 13:47:46 -0700 


Taragolis opened a new pull request, #24425:
URL: https://github.com/apache/airflow/pull/24425

   At that moment additional extra fields in Provider Connection always orders 
in alphabetical order of their keys.
   So there is no possible to change this order in UI.
   
   This PR remove sorts original dictionary and keep it stored in original 
order that it defined in Hook.
   
   Probably I miss idea of this additional transformation dict -> sorted tuples 
-> OrderedDict, or probably it kept since time when Airflow supported Python 3.5
   
   <details>
     <summary>Snowflake Connection Example</summary>
   
   
https://github.com/apache/airflow/blob/6d69dd062f079a8fbf72563fd218017208bfe6c1/airflow/providers/snowflake/hooks/snowflake.py#L86-L110
   
   ### Before Changes
   
![snowflake-before](https://user-images.githubusercontent.com/3998685/173441355-94d7c651-d4b5-4294-990b-b1abf55d951c.jpeg)
   
   ### After Changes
   
![snowflake-after](https://user-images.githubusercontent.com/3998685/173441372-6b209689-b3a5-4df0-8c0d-754658ec62e7.jpeg)
   
   </details>
   
   
   <details>
     <summary>K8S Connection Example</summary>
   
   
https://github.com/apache/airflow/blob/6d69dd062f079a8fbf72563fd218017208bfe6c1/airflow/providers/cncf/kubernetes/hooks/kubernetes.py#L84-L107
   
   ### Before Changes
   
![k8s-before](https://user-images.githubusercontent.com/3998685/173441627-ee68719d-31a4-4a40-824b-5bb0216dab10.jpeg)
   
   ### After Changes
   
![k8s-after](https://user-images.githubusercontent.com/3998685/173442126-91d18a1a-af88-4212-8dc1-6f43808a9ad8.png)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to