Taragolis commented on PR #24425: URL: https://github.com/apache/airflow/pull/24425#issuecomment-1155003343
> We probably should sort the output there, or at least add a flag to toggle the sorting behaviour. This can be significant if there are a lot of entries in the list. If we talk about cli `airflow providers` is it mean that in anyway if we call command it would order exactly once in any case? So move sorts in cli part doesn't affect anything https://github.com/apache/airflow/blob/fe2ef0fcc75fa7be9e1ec1113af260a3a3c9e7ae/airflow/cli/commands/provider_command.py#L82-L93 > And using OrderedDict in this is case is "intent signalling" - no more, no less. Oh it some kind of "Holy War. Just personal thoughts since preserve `dict` keys orders as part of the language standard in the most cases there is no reason explicit use `OrderedDict`. I think `OrderedDict` useful nowadays only when you need compare two dict and be sure that the order exactly the same. Because there is no differences between dict(sorted(d.items())) and OrderedDict(sorted(d.items)), rather than interacting with dict has slightly better performance. But again that just personal thoughts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
