Taragolis commented on PR #24425: URL: https://github.com/apache/airflow/pull/24425#issuecomment-1154870547
> OrderedDict is fine, they don’t add overhead anyway and it’s of minimal benefit to actively remove them. Actually the do add overhead but agree that the beneficial is minimal - Airflow doesn't actively use OrderedDict > It’s this OrderedDict(sorted()) combination that’s problematic, which is why I wonder about _field_behaviours specifically. I could also remove this line. https://github.com/apache/airflow/blob/34e4073316fced72183255390835b6baebd44cbb/airflow/providers_manager.py#L654 Initially I removed both line, but then I realise that only `_connection_form_widgets` affect to order fields elements in UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
