rino0601 commented on code in PR #24373: URL: https://github.com/apache/airflow/pull/24373#discussion_r903430423
########## newsfragments/24373.improvement.rst: ########## @@ -0,0 +1 @@ +Support config ``[logging]log_formatter_class`` for overriding logging.Formatter Review Comment: @uranusjr I misinterpreted significant as breaking change. Referring to the following paragraph of the contribution guide, it seems that 'body' to explain the procedure is supported only in the 'significant' type. is that right? >In general newsfragments must be one line. For newsfragment type `significant`, you may include summary and body separated by a blank line, similar to `git` commit messages. If so, I think you should change it to a significant type and put the explanation you suggested. thanks for the comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
