rino0601 commented on code in PR #24373:
URL: https://github.com/apache/airflow/pull/24373#discussion_r899729793
##########
airflow/utils/log/colored_log.py:
##########
@@ -43,6 +43,9 @@ class CustomTTYColoredFormatter(TTYColoredFormatter):
traceback.
"""
+ default_time_format = '%Y-%m-%d %H:%M:%S%z'
+ default_msec_format = '%s %03dms'
Review Comment:
@bbovenzi
After I git rebase onto main:
> A lot of thoughts went through my mind when I saw this screen. 😢
It would be desirable to fix it in this PR because it takes more effort to
find and process it later. so I've spend some times try to fix it. it seems
that if I fix the regular expression in
`grid/details/content/taskInstance/Logs/utils.js` I can fix it for now, but if
I do, as you concerned, we will have two log parsers.
Then I stopped trying, to ask you comment. Also, my front-end knowledge is
frozen in the days of react15, so I need some time to review if I understand
the grid code properly.
---
Anyway,
I wonder if logs in the grid view feature will be released in 2.3 or 2.4.
If it's going to be released in 2.4, so if this PR also has to go out in 2.4
too, I'd like to know in advance.
I'm using 1.10.15 at work, and dozens of instances are stuck with that
version. I recently migrated one instance to 2.3.2 as a pilot. Then I
discovered this time zone problem. Therefore, other instances are waiting for
the result of this PR.
My co-worker's previous contribution was classified as a minor release, it
took 5 months to release. If this PR is going to be classified as minor
release, I would like to say "migrate now (with workaround config)" to my
colleagues because I can guess that it will be released in a few months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
