potiuk commented on code in PR #23560:
URL: https://github.com/apache/airflow/pull/23560#discussion_r913081767
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
# ``{{"connections_prefix": "/airflow/connections", "profile_name":
"default"}}``
backend_kwargs =
+# Advanced secrets backend configuration, allow to user configure more than
one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+#
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =
Review Comment:
I think it woudl be nice to add the default way of configuration as config.
It would give the user an opportunity to figure out how to do it without
reaching to documentation.
There are two kinds of users, those who love reading the docs, and those who
prefer to explore. Comment (or even default value written here would actually
be nice one for the latter group.
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
# ``{{"connections_prefix": "/airflow/connections", "profile_name":
"default"}}``
backend_kwargs =
+# Advanced secrets backend configuration, allow to user configure more than
one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+#
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =
Review Comment:
I think it woudl be nice to add the default way of configuration as config.
It would give the user an opportunity to figure out how to do it without
reaching to documentation.
There are two kinds of users, those who love reading the docs, and those who
prefer to explore. Comment (or even default value written here) would actually
be nice one for the latter group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
