potiuk commented on code in PR #23560:
URL: https://github.com/apache/airflow/pull/23560#discussion_r913107498
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
# ``{{"connections_prefix": "/airflow/connections", "profile_name":
"default"}}``
backend_kwargs =
+# Advanced secrets backend configuration, allow to user configure more than
one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+#
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =
Review Comment:
I realized that we cannot do that actually - because lack of the
`backend_congigs` determines if we should use backend and backend_kwargs - by
adding default we would break compatibiliyt if someone generates the default
config and moves their "backend/backend_kwarg" - it's mabe not very proabable
scenario but might happen
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
# ``{{"connections_prefix": "/airflow/connections", "profile_name":
"default"}}``
backend_kwargs =
+# Advanced secrets backend configuration, allow to user configure more than
one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+#
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =
Review Comment:
I realized that we cannot do that actually - because lack of the
`backend_configs` determines if we should use backend and backend_kwargs - by
adding default we would break compatibiliyt if someone generates the default
config and moves their "backend/backend_kwarg" - it's mabe not very proabable
scenario but might happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
