potiuk commented on code in PR #23560:
URL: https://github.com/apache/airflow/pull/23560#discussion_r913110114
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
# ``{{"connections_prefix": "/airflow/connections", "profile_name":
"default"}}``
backend_kwargs =
+# Advanced secrets backend configuration, allow to user configure more than
one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+#
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =
Review Comment:
One more thing - I think we shoudl raise a deprecation warning when
backend/backend_kwargs is used and maybe even provide a detailed information
how backends_config should look like in this case? We should have enough info
to work-out what should be the replacement?
Also another warning should be raised when 'backends_config` is defined and
either of the `backend_kwargs`, `backend` are set. This **might** happen that
someone will set the three of them, and backends_config should get precedence,
but it should also raise warnig to the user to remove the two old settings -
this might be a mistake on the side of configuring user, and in the worst case
it should lead to cleaer and less ambiguous config eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
