josh-fell commented on code in PR #24931:
URL: https://github.com/apache/airflow/pull/24931#discussion_r917040105


##########
tests/utils/test_compression.py:
##########
@@ -54,8 +54,8 @@ def setUp(self):
                 f_bz2.writelines([header, line1, line2])
 
         # Base Exception so it catches Keyboard Interrupt
-        except BaseException as e:
-            logging.error(e)
+        except BaseException:
+            logging.exception("An exception has occurred.")

Review Comment:
   The flake8-logging-format extension isn't fond of using the exception itself 
in the logging message.
   
   `G200 Logging statements should not include the exception in logged string 
(use exception or exc_info=True)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to