potiuk commented on code in PR #24931:
URL: https://github.com/apache/airflow/pull/24931#discussion_r918703890
##########
tests/providers/apache/hive/transfers/test_s3_to_hive.py:
##########
@@ -107,8 +107,8 @@ def setUp(self):
self._set_fn(fn_bz2, '.bz2', False)
f_bz2_nh.writelines([line1, line2])
# Base Exception so it catches Keyboard Interrupt
- except BaseException as e:
- logging.error(e)
+ except BaseException:
Review Comment:
This is rather strange - why do we need except/calling tearDown at all?
tearDown should be called regardless (and BTW. we should convert it to fixture
providing tmpdir (and cleaning it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
