Taragolis commented on PR #25494: URL: https://github.com/apache/airflow/pull/25494#issuecomment-1205813393
I'm still worry of fact that 'host' has additional logic on URI parse which could add additional complexity - in the fact it only happen if user do not follow documentation and do not URL-encoded their values https://github.com/apache/airflow/blob/298be502c35006b7c3f011b676dbb4db0633bc74/airflow/models/connection.py#L50-L60 And a little clarification just for sure that we on the same page. Not just renaming, we deprecate value just for sure that users have a time to change their connections before actually this parameter would be removed. Something like that ```python self.endpoint_url = extra.get("endpoint_url") if not self.endpoint_url and "host" in extra: self.endpoint_url = conn.host warnings.warn( "some deprecation warning", DeprecationWarning, stacklevel=2, ) ``` And also it would be nice to add this [in to the documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/connections/aws.html#configuring-the-connection) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
