josh-fell commented on code in PR #25494:
URL: https://github.com/apache/airflow/pull/25494#discussion_r940181581


##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -154,6 +154,16 @@ def __post_init__(self, conn: "Connection"):
 
         self.endpoint_url = extra.get("host")
 
+        if self.endpoint_url:
+            warnings.warn(
+                "extra['host'] is deprecated and will be removed in a future 
release."

Review Comment:
   @potuik If the [Amazon provider is going to be a major version 
bump](https://lists.apache.org/thread/c9254qscbf6yjpqx6q4n3o798pxxyfwk) this 
month, is the deprecation message even required? The provider could just stop 
supporting the `host` connection field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to