potiuk commented on PR #25980:
URL: https://github.com/apache/airflow/pull/25980#issuecomment-1242407785
> ok sure, let's do it then.
>
> @potiuk rather than "auto updating" the conn type, why don't we just warn
the user? e.g. in `base_aws.py` we can add something like
>
> ```
> if str(connection.conn_type).lower() == 's3':
> warnings.warn(
> f"connection '{connection.conn_id}' has
conn_type='s3', which is a deprecated conn "
> f"type. type 's3' is deprecated. Please update it
to have conn type 'aws'."
> )
> ```
>
> after it retrieves the conn.
>
> then it seems fair to immediately remove this conn type.
yep. Warning is better. I also do not like "auto" modifications...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
