RachitSharma2001 commented on code in PR #26974:
URL: https://github.com/apache/airflow/pull/26974#discussion_r992575427


##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -221,6 +221,12 @@ if [[ ${SKIP_ENVIRONMENT_INITIALIZATION=} != "true" ]]; 
then
         ssh-keyscan -H localhost >> ~/.ssh/known_hosts 2>/dev/null
     fi
 
+    sudo apt-get update && sudo apt-get install -y vsftpd
+    mkdir /ftphome
+    sudo chown airflow:airflow /ftphome
+    echo "write_enable=YES" >> /etc/vsftpd.conf
+    sudo service vsftpd restart

Review Comment:
   I see, but I saw from the SFTPOperator tests that they also pull up an local 
ssh server and use it directly for testing as opposed to mocking the server 
(tests 
[here](https://github.com/apache/airflow/blob/main/tests/providers/sftp/operators/test_sftp.py)).
 I thought that, for consistency and accuracy purposes, it would make sense to 
do the same for the FTPOperator. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to