uranusjr commented on code in PR #26974:
URL: https://github.com/apache/airflow/pull/26974#discussion_r993238368
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -221,6 +221,12 @@ if [[ ${SKIP_ENVIRONMENT_INITIALIZATION=} != "true" ]];
then
ssh-keyscan -H localhost >> ~/.ssh/known_hosts 2>/dev/null
fi
+ sudo apt-get update && sudo apt-get install -y vsftpd
+ mkdir /ftphome
+ sudo chown airflow:airflow /ftphome
+ echo "write_enable=YES" >> /etc/vsftpd.conf
+ sudo service vsftpd restart
Review Comment:
I’d argue there’s a limit on being thorough and the SFTP tests are probably
too much trouble to be worthwhile. They are already there so there’s less
reason to rewrite them, but it’s better for new code to be tested in a more
lightweight fashion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
