RachitSharma2001 commented on code in PR #26974:
URL: https://github.com/apache/airflow/pull/26974#discussion_r993713609
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -221,6 +221,12 @@ if [[ ${SKIP_ENVIRONMENT_INITIALIZATION=} != "true" ]];
then
ssh-keyscan -H localhost >> ~/.ssh/known_hosts 2>/dev/null
fi
+ sudo apt-get update && sudo apt-get install -y vsftpd
+ mkdir /ftphome
+ sudo chown airflow:airflow /ftphome
+ echo "write_enable=YES" >> /etc/vsftpd.conf
+ sudo service vsftpd restart
Review Comment:
That make sense. I have replaced the tests with more lightweight unit tests
(see
[here](https://github.com/RachitSharma2001/airflow/blob/main/tests/providers/ftp/operators/test_ftp.py)).
I modeled these tests after
[test_sftp](https://github.com/apache/airflow/blob/main/tests/providers/sftp/operators/test_sftp.py),
with the difference being that the FTP server is mocked. Let me know if these
tests make sense, and if there are any other changes that should be made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
