Taragolis commented on code in PR #26949:
URL: https://github.com/apache/airflow/pull/26949#discussion_r996447381
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -118,13 +128,13 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
stacklevel=2,
)
config = emr_conn.extra_dejson.copy()
- config.update(job_flow_overrides)
+ config.update(**job_flow_overrides)
Review Comment:
> So, any values used in job_flow_overrides needs to be a subset of the
possible values from RunJobFlowInputRequestTypeDef.
>Please let me know if I'm missing something.
Yeah it might be a subset but separately it not required as
`RunJobFlowInputRequestTypeDef`.
So might be better keep annotation as it is: `dict(str, Any)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
