o-nikolas commented on code in PR #26949:
URL: https://github.com/apache/airflow/pull/26949#discussion_r996456391
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -118,13 +128,13 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
stacklevel=2,
)
config = emr_conn.extra_dejson.copy()
- config.update(job_flow_overrides)
+ config.update(**job_flow_overrides)
Review Comment:
@dakshin-k
I don't know EMR well enough to say for sure, but if you're confident all
valid values that can be in the dict now or in the future will be valid
arguments to a function in python (i.e. stringifiable keys) then feel free to
keep what you have (and my gut says you're probably right about that).
Also I do like @Taragolis suggested type hint as well :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
