Taragolis commented on code in PR #26949:
URL: https://github.com/apache/airflow/pull/26949#discussion_r996462306
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -118,13 +128,13 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
stacklevel=2,
)
config = emr_conn.extra_dejson.copy()
- config.update(job_flow_overrides)
+ config.update(**job_flow_overrides)
Review Comment:
In additional it might difficult to keep valid definition (keys for specific
boto3 client methods).
Due to my past experience is method support specific parameters not only
depend on current AWS API but also depends on `boto3` and `botocore` version.
I have been in the position when I need to upgrade `boto3` version to lowest
version which support `Concurrecy` in `run_job_flow` method. Fortunately it
was happen couple years ago and couple years ago `boto3` and `botocore` has a
bit strange cross dependencies and almost every time use pinned version of
`requests`, right not it not a problem.
And second situation `mypy-boto3-<service-name>` should be the same version
as `boto3` otherwise it would show incorrect annotation. I don't think it is
possible to achieve this so all annotation it is more _nice feature_ rather
than actual strict definition of `boto3` client methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
