pierrejeambrun commented on code in PR #26872:
URL: https://github.com/apache/airflow/pull/26872#discussion_r1000948366
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -102,13 +102,13 @@ class DbApiHook(BaseForDbApiHook):
"""
# Override to provide the connection name.
- conn_name_attr = None # type: str
+ conn_name_attr: str | None = None
Review Comment:
I did that because it was clashing with the definition of this class
attribute in `BaseDatabricksHook` and `QuboleHook`. (when inheriting from both
of them for instance in `QuboleCheckHook`, or `DatabricksSqlHook`)
But you are right, it should be a 'str' here and also in
`BaseDatabricksHook` and `QuboleHook`.
I just updated that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
