pierrejeambrun commented on code in PR #26872:
URL: https://github.com/apache/airflow/pull/26872#discussion_r1004706756
##########
airflow/providers/google/cloud/hooks/datastore.py:
##########
@@ -279,11 +270,10 @@ def export_to_storage_bucket(
:param labels: Client-assigned labels.
:param project_id: Google Cloud project ID against which to make the
request.
:return: a resource operation instance.
- :rtype: dict
"""
- admin_conn = self.get_conn() # type: Any
+ admin_conn = self.get_conn()
- output_uri_prefix = "gs://" + "/".join(filter(None, [bucket,
namespace])) # type: str
+ output_uri_prefix: str = "gs://" + "/".join(filter(None, [bucket,
namespace]))
Review Comment:
Yep better. Did that for both of them, also renamed the local variable
`output_uri_prefix` to `output_url_prefix` for consistency. It is used as an
`outputUrlPrefix`sor 'uri' doesn't make sense to me here.
```python
body = {
"outputUrlPrefix": output_url_prefix,
"entityFilter": entity_filter,
"labels": labels,
}
```
cf:
https://github.com/apache/airflow/commit/409818b7450d57fb79a29a71c6be98a4b3adb6b8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
