pierrejeambrun commented on code in PR #26872:
URL: https://github.com/apache/airflow/pull/26872#discussion_r1004703748
##########
airflow/providers/exasol/hooks/exasol.py:
##########
@@ -216,22 +216,20 @@ def get_autocommit(self, conn) -> bool:
:param conn: Connection to get autocommit setting from.
:return: connection autocommit setting.
- :rtype: bool
"""
autocommit = conn.attr.get("autocommit")
if autocommit is None:
autocommit = super().get_autocommit(conn)
return autocommit
@staticmethod
- def _serialize_cell(cell, conn=None) -> object:
+ def _serialize_cell(cell, conn=None) -> object: # type: ignore[override]
Review Comment:
I like it, much cleaner thanks. Done for all 3 occurences of that, cf
409818b7450d57fb79a29a71c6be98a4b3adb6b8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
