o-nikolas commented on code in PR #27184:
URL: https://github.com/apache/airflow/pull/27184#discussion_r1007576007
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -491,9 +491,12 @@ def exec_ssh_client_command(
if stdout_buffer_length > 0:
agg_stdout += stdout.channel.recv(stdout_buffer_length)
+ timedout = False
+
# read from both stdout and stderr
while not channel.closed or channel.recv_ready() or
channel.recv_stderr_ready():
readq, _, _ = select([channel], [], [], timeout)
+ timedout = len(readq) == 0
Review Comment:
I don't have a deep enough understanding of the select api and ssh to know
for sure, but it seems harmless to check the others.
If you're positive that this is correct then I'm happy to commit and
approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
