o-nikolas commented on code in PR #27184:
URL: https://github.com/apache/airflow/pull/27184#discussion_r1008653675
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -491,9 +491,12 @@ def exec_ssh_client_command(
if stdout_buffer_length > 0:
agg_stdout += stdout.channel.recv(stdout_buffer_length)
+ timedout = False
+
# read from both stdout and stderr
while not channel.closed or channel.recv_ready() or
channel.recv_stderr_ready():
readq, _, _ = select([channel], [], [], timeout)
+ timedout = len(readq) == 0
Review Comment:
> what's the next step to get this merged?
There are some static checks that are failing which need fixing before it
can be merged. You can enable pre-commit to run static checks on your code
before submitting a PR update
([readme](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#installing-pre-commit-hooks))
Then someone with committer status will need to review/approve/merge the
change :) (CC: @eladkal @potiuk)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
