jedcunningham commented on code in PR #27848:
URL: https://github.com/apache/airflow/pull/27848#discussion_r1029975838
##########
chart/templates/_helpers.yaml:
##########
@@ -214,8 +214,10 @@ If release name contains chart name it will be used as a
full name.
value: "repo"
- name: GIT_SYNC_ADD_USER
value: "true"
- - name: GIT_SYNC_WAIT
+ - name: GIT_SYNC_WAIT # Deprecated: use GIT_SYNC_PERIOD
value: {{ .Values.dags.gitSync.wait | quote }}
+ - name: GIT_SYNC_PERIOD
+ value: {{ .Values.dags.gitSync.period | quote }}
Review Comment:
Since `wait` is used when both are set, we might as well stick with just
`wait` here as we can't remove it (yet).
##########
chart/values.schema.json:
##########
@@ -5254,6 +5254,11 @@
"default": "tests/dags"
},
"wait": {
+ "description": "Interval between git sync attempts
in seconds. High values are more likely to cause DAGs to become out of sync
between different components. Low values cause more traffic to the remote git
repository. (Deprecated. Use 'period')",
+ "type": "integer",
+ "default": 5
Review Comment:
We [just reduced this from 60](https://github.com/apache/airflow/pull/27625)
to reduce the risk of them being out of sync. If you want to pitch another
value, definitely so that in another PR.
##########
chart/values.yaml:
##########
@@ -93,7 +93,7 @@ images:
pullPolicy: IfNotPresent
gitSync:
repository: k8s.gcr.io/git-sync/git-sync
- tag: v3.4.0
+ tag: v3.6.1
Review Comment:
This single line might be all we end up keeping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
